Location of the Doctrine proxy classes
Permalink
Just wondering why the location of the Doctrine proxy classes is set within the concrete directory?
I mean the config in /concrete/config/database.php, it says:
Because when I'm generating my own proxies, they will also be in the core because of this setting. And now when the core is updated, they will be gone. Rather annoying e.g. for package development purposes... When a user of the package swaps out the core, all proxies need to be regenerated manually.
Shouldn't this be e.g. in /application/proxies? Or is there something I'm missing again?
Kind of hard to see the thought behind any of the architecture without any documentation...
I mean the config in /concrete/config/database.php, it says:
// ... 'proxy_classes' => DIR_BASE_CORE . '/config/doctrine', // ...
Because when I'm generating my own proxies, they will also be in the core because of this setting. And now when the core is updated, they will be gone. Rather annoying e.g. for package development purposes... When a user of the package swaps out the core, all proxies need to be regenerated manually.
Shouldn't this be e.g. in /application/proxies? Or is there something I'm missing again?
Kind of hard to see the thought behind any of the architecture without any documentation...
I don't think you can do that. But even if you could, I think it would become a slight inconvenience if we provided the same packaged code for someone else to use.
EDIT: + I guess the core proxies still need to be there (although I'm not sure whether they are used anywhere currently, but maybe at some point).
EDIT: + I guess the core proxies still need to be there (although I'm not sure whether they are used anywhere currently, but maybe at some point).
Bump?
good discussion on this happening over here:
https://github.com/concrete5/concrete5-5.7.0/issues/1469#issuecommen...
https://github.com/concrete5/concrete5-5.7.0/issues/1469#issuecommen...
Here's an example implementation on using the Doctrine entities within a concrete5 package:
https://github.com/mainio/c5_entities_example...
It uses a custom composer package that provides the functionality for installation and uninstallation logic. Hopefully we'll get some easier way straight into the core at some point, there is some discussion going on about this in the github issue thread that @andrew linked above.
https://github.com/mainio/c5_entities_example...
It uses a custom composer package that provides the functionality for installation and uninstallation logic. Hopefully we'll get some easier way straight into the core at some point, there is some discussion going on about this in the github issue thread that @andrew linked above.
-Steve