Testimonial URLs not working

Permalink
Hi

When I type this URL in the testimonial block:
http://allaboutyoumk.co.uk


Concrete5 outputs it like:
http%3A%2F%2Fallaboutyoumk.co.uk


You can see it on this site:http://similize.com

How do I fix that?

Thanks

brianskov
 
MrKDilkington replied on at Permalink Reply
MrKDilkington
Hi brianskov,

The address is being URL encoded with the urlencode() function.

This is one of two places where it is being done.
https://github.com/concrete5/concrete5/blob/develop/web/concrete/blo...

As an example, it is making an address like "http://concrete5.org" display as "http://localhost/concrete5/index.php/http%3A%2F%2Fconcrete5.org".

I believe the use of urlencode() in this file is a mistake. If someone else can confirm that it is a mistake, I will make a pull request with the change.
brianskov replied on at Permalink Reply
brianskov
Yes I guessed that it was URL encoded - but didn't understand why.

Will someone be able to fix it soon?

If I decide to fix it myself - will it be overwritten with next update?
MrKDilkington replied on at Permalink Reply
MrKDilkington
If someone confirms that urlencode() should not have been used, then I will upload a fix today.

If the fix is accepted, then it will be available in the next concrete5 5.7.5 release. This release is due out soon.

In the meantime, you can fix it yourself and remember that an update will overwrite it.
andrew replied on at Permalink Reply
andrew
You're correct. We should not be urlencoding() this URL. I'm sure this is a result of an overzealous security-related pull request we applied without doing proper testing on. I'll approve it quickly if it can get in
brianskov replied on at Permalink Reply
brianskov
Thanks for the help.

I have fixed it manually for now.

Will it be fixed in next update?
MrKDilkington replied on at Permalink Reply
MrKDilkington
The fix was submitted last night. It should be part of the next update.