5.4.2 Update

Permalink
Heads up!

Installed the update yesterday and it screwed up my style sheet?

It seems 5.4.2 is not so forgiving with theme styles.

I had to prepend a lot more of my styles with the '#wrap' bit.

So if you update and things go a bit mad, you might want to look at your style sheet.

One thing I did find strange I had to force my background colour with !important.

I shall not be updating clients until I've double checked all style sheets.

Steevb
 
GregJoyce replied on at Permalink Reply
GregJoyce
Any chance you can get us a copy of a theme where this problem happens and ideally its fixed version as well so we can take a look at what's going on / see how serious this is?
Steevb replied on at Permalink Reply
Steevb
Greg,

The theme is my own and all that is wrong is that I didn't do as I was told!

Originally we were told about GREEDY CSS files and we need to cover our styles with a wrapper '#wrapper .head, #wrapper .nav, etc.

I did this most of the time, but had problems with validation, for instance #wrap #content #inner .text or #wrap #nav ul li a was not very good. So I stopped and C5 did not seem to mind to much.
But now it seems it does!

Not a problem, just need to adjust accordingly.
Steevb replied on at Permalink Reply
Steevb
Actually on hindsight,

Could it be Concrete 5.4.2 doesn't understand HTML5 or CSS3?

My site uses HTML5 and CSS3.

The other one I updated doesn't?

Interesting!

Have to look into that
GregJoyce replied on at Permalink Reply
GregJoyce
Oh ok, sounds good.

No, I don't think 5.4.2 would have any problem with the html / css stuff -- when you get down to it c5 and php are just text preprocessors that shoot stuff at your browser, so it shouldn't care what you want to say.
Steevb replied on at Permalink Reply
Steevb
Hey Greg,

You could be right, it has not done it before.

But wondering if because it's calling - /updates/concrete5.4.2/

Not normal path, that may cause a problem?

Not sure.
GregJoyce replied on at Permalink Reply
GregJoyce
Not sure, can't really say without something in front of me. Going into the updates/ folder is what it should be doing but I don't know why it would be invalidating any CSS
Steevb replied on at Permalink Reply
Steevb
Hey Greg,

I going to say it's my fault, and until I have found out exactly what's going on (I think my style sheet), can't say anymore for now.

Obviously something is not playing well with something else.

Will post when I get a true reading on this, thanks for listening.
GregJoyce replied on at Permalink Reply
GregJoyce
Awesome, yeah we'd appreciate seeing what you find out.