After Upgrading Concrete5 site from 5.4.2.2 to 5.6.3.5, the footer only appears on some pages.
Permalink
The theme's footer.php file contains the line "<?php Loader::element('footer_required'); ?>" before the closing </body> tag.
I've also attempted to clear the cache manually, though the CMS & via the browser, but still no luck.
I've also attempted to clear the cache manually, though the CMS & via the browser, but still no luck.
If you have a link to your site would be helpful.
I have messaged you on Slack with the domain requested.
Seems like it's an issue with the sidebar in the theme's default.php file.
Removing the above brings the footer back, but obviously removes the sidebar.
<div id="sidebar" class="col_3 omega">
<?php
$as = new Area('Sidebar');
$as->display($c);
?>
</div><!-- #sidebar ends -->Removing the above brings the footer back, but obviously removes the sidebar.
There were some changes to the way theme headers and footers are built between 5.4 and 5.6 (I think it was 5.5 that made the change). One symptom is failure to include assets.
[edit] There could also be broken HTML if the full footer is not included[/edit]
Have a look at what Greek Yogurt does for header/footer inclusion and compare that to your theme.
For details, probably best to read back through release notes of all the intervening versions.
[edit] There could also be broken HTML if the full footer is not included[/edit]
Have a look at what Greek Yogurt does for header/footer inclusion and compare that to your theme.
For details, probably best to read back through release notes of all the intervening versions.
Footer now seems to display fine if the sidebar is removed in the default.php file. Which is odd, it seems like it'll either be have a sidebar or have a footer.
Code seems pretty much the same between the Slate theme and the Greek Yogurt theme.
[edit] Seems like everything AFTER the Sidebar is removed, assuming issue lies with the Sidebar itself. [/edit]
Theme used is:https://www.concrete5.org/marketplace/themes/slate...
Code seems pretty much the same between the Slate theme and the Greek Yogurt theme.
[edit] Seems like everything AFTER the Sidebar is removed, assuming issue lies with the Sidebar itself. [/edit]
Theme used is:https://www.concrete5.org/marketplace/themes/slate...
If you remove the sidebar and the footer appears sounds like a closing div tag might be missing like we were talking about on slack.
Hey Firstint
Did you ever get this figure out?
Did you ever get this figure out?
