on_page_version_add event does not return version comments

Permalink October 10, 2011 at 11:08 AM

Hi!
I set up notifications on page edits for my site. I would like to be informed about the comments, submitted for edited pages. Here's the code:

function on_page_version_add($page, $nv) {
  $l = new Log('content-change', true);
  if ($page->getCollectionPath()!=''){
    $l->write($nv->getVersionAuthorUserName() . " have changed page '" . $page->getCollectionName() . "'.");
    $l->write(BASE_URL . DIR_REL . $page->getCollectionPath());
  } else {
    $parent = Page::getByID($page->getCollectionParentID(), $version = 'RECENT');
    $l->write($nv->getVersionAuthorUserName() . " have changed page '" . $page->getCollectionName() . "' under the '" . $parent->getCollectionName() . "' page (" . BASE_URL . DIR_REL . $parent->getCollectionPath() . " ).");
  }
  $l->write("Comment: " . $cv->getVersionComments() );
  $l->close();
}

Unfortunately, instead of real version comment it returns something like default comment - "New Version 89". What am I doing wrong?

campbell replied on Nov 3, 2011 at 3:07 pm Permalink Reply

Well, as far as I can tell (and I've been buried in this change notification stuff quite a bit), the on_page_version_add event fires as soon as an update to a block within the page is made. Because this event fires before the user clicks the Exit Edit Mode button (which, as you know, is where the option to enter version comments exists), the version is given a default name and number.

If there was a way to tie the notification to the Preview My Edits or Publish My Edits button clicks, that would theoretically make things work (or at least work right up until someone entered and exited edit mode without modifying anything, which will clear the most recent version comments back to a default... it's a bug).

Shotster replied on Nov 3, 2011 at 3:29 pm Permalink Reply

> (or at least work right up until someone entered and exited edit mode without
> modifying anything, which will clear the most recent version comments back to a
> default... it's a bug)

I've noticed some weirdness with version comments but never took the time to pin it down. Thanks for mentioning this. Has it been reported in the bug database?

-Steve

campbell replied on Nov 3, 2011 at 3:45 pm Permalink Reply

I did add a bug report for it a couple of days ago, yep. :)

Post Reply

Delete Post

You are allowed to delete your post for 5 minutes after it's posted.

Delete

Mark Post as Spam

Are you sure you would like to mark this post as spam?

Mark as Spam

Destroy Spammer

This script will report this post as spam and add a permanent IP ban for this user, type "DESTROY" below to continue.

DESTROY SPAMMER

Sign In?

You must have a user account and be signed to perform this action.

This website stores cookies on your computer. These cookies are used to improve your website experience and provide more personalized services to you, both on this website and through other media. To find out more about the cookies we use, see our Privacy Policy.

Forums

Chit-Chat