Chit-Chat

<?php
echo Config::get('concrete.site');
?>

 

mnakalay replied on Dec 6, 2016 at 3:59 pm Permalink Reply

I upgraded my site to v8 and this is still working

PineCreativeLabs replied on Dec 6, 2016 at 4:18 pm Permalink Reply

I can confirm this. Tried it with different themes, got the same result. I have reported this as a bug:

https://www.concrete5.org/developers/bugs/8-0-0/site-name-does-not-r...

mnakalay replied on Dec 6, 2016 at 4:44 pm Permalink Reply

that is really weird because even in the controller for the register single page, it is being used in the email sent

$mh->addParameter('site', tc('SiteName', $config->get('concrete.site')));

ramonleenders replied on Dec 6, 2016 at 5:39 pm Permalink Reply

This isn't a bug, the code just changed. Take a look in the header_required file how they pull the site config:

https://github.com/concrete5/concrete5/blob/develop/concrete/element...

It's not Config::get anymore. Try this:

$site = Core::make('site')->getSite();
$config = $site->getConfigRepository();
echo $config->get('site');

If that didn't work, I will paste the correct code tomorrow. I'm not on my desktop, so quite limited.

tallacman replied on Dec 6, 2016 at 5:49 pm Permalink Reply

thanks but that doesnt work at least in my attempt.

mnakalay replied on Dec 6, 2016 at 5:54 pm Permalink Reply

try

\Core::make('site')->getSite()->getSiteName();

I think ramonleenders' code would work like this

$site = Core::make('site')->getSite();
$config = $site->getConfigRepository();
echo $config->get('name');

PineCreativeLabs replied on Dec 6, 2016 at 11:43 pm Permalink Reply

This does work for me:

$site = Core::make('site')->getSite();
$config = $site->getConfigRepository();
echo $config->get('name');

The old code is going to be a big problem, because many of the themes use this, which will break a lot of sites that are using it, if they upgrade to 8 and newer.

c5hub replied on Dec 7, 2016 at 4:17 am Permalink Reply

This may or may not be the preferred method but should work...

<?php
echo Config::get('site.sites.default.name');
?>

Steevb replied on Dec 7, 2016 at 12:28 pm Permalink Best Answer Reply

Code above worked for me this afternoon, thanks.

Quick workaround to cover 5.7 and 5.8. Needs a bit of work to target versions (Shows two links in source code).

<a href="<?php echo DIR_REL?>/"><?php echo Config::get('concrete.site');?></a>
          <a href="<?php echo DIR_REL?>/"><?php echo Config::get('site.sites.default.name');?></a>

tallacman replied on Dec 7, 2016 at 1:01 pm Permalink Reply

Thanks to all. Looks like we have a winner. Until v8.0.1 at least.

tallacman replied on Dec 7, 2016 at 1:05 pm Permalink Reply

It fails on the first call in 8.0 but the second picks it up. Time to update themes.

Steevb replied on Dec 7, 2016 at 1:18 pm Permalink Reply

like I mentioned, it shows two home links in source code. Visitors/users don't see them but search engines will. Great for SEO?

tallacman replied on Dec 8, 2016 at 12:07 pm Permalink Reply

8.0.1 fixes this