Developing (v7+)

[5.7] Image to JPG when generating a thumbnail?

Permalink June 03, 2015 at 9:45 AM

Many of the images on my website are uploaded in PNG format.
When I am generating a thumbnail from them, I'd like to convert them to JPG.

I do have something like this:

<?php 
use \Imagine\Image\ImageInterface;
use \Concrete\Core\File\Image\Thumbnail\Thumbnail as Thumbnail;
use \Concrete\Core\File\Image\Thumbnail\Type\Type;
$type = new Type();
$type = $type->getByHandle('average_image');
if(!$type){
   $type = new Type();
   $type->setHeight(50);
   $type->setWidth(50);
   $type->setName('AverageImage');
   $type->setHandle('average_image');
   $type->save();
}
$f = File::getByID(1);

Viewing 15 lines of 19 lines. View entire code block.

<?php 
 
use \Imagine\Image\ImageInterface;
use \Concrete\Core\File\Image\Thumbnail\Thumbnail as Thumbnail;
use \Concrete\Core\File\Image\Thumbnail\Type\Type;
 
 
$type = new Type();
$type = $type->getByHandle('average_image');
if(!$type){
   $type = new Type();
   $type->setHeight(50);
   $type->setWidth(50);
   $type->setName('AverageImage');
   $type->setHandle('average_image');
   $type->save();
}
 
 
$f = File::getByID(1);
 
$path_thumbnail = $f->getThumbnailURL('average_image');
if(!$path_thumbnail)
   $f->rescanThumbnails();
 
?>

However, this outputs a PNG file with a .jpg extension - with transparency and everything.

PineCreativeLabs replied on Jun 3, 2015 at 11:12 am Permalink Reply

Somewhere in your output, you could use str_replace to drop the PNG extenstion. For example:

$image = 'path_thumbnail';
$search = 'png';
$trimmed = str_replace($search, "", $image);
echo $trimmed;

Or something like that.

VPenkov replied on Jun 4, 2015 at 8:05 am Permalink Best Answer Reply

Yeah, not sure if that solves anything. I've opened a GitHub issue (https://github.com/concrete5/concrete5/issues/2556), let's see what the core team thinks about this.

Meanwhile, what we did was copy the old image helper with some light modifications. Here's what we did:
1) Create folder: /application/src/
2) Create file: /application/src/JpegImageHelper.php with the following content:

<?php
namespace Application\Src;
use Config;
use Loader;
use Image;
use \Imagine\Image\Box;
use Imagine\Image\ImageInterface;
use \Imagine\Image\Point\Center;
use \Concrete\Core\File\File;
class JpegImageHelper
{   
    function replace_extension($filename, $new_extension) {
        $info = pathinfo($filename);
        return $info['filename'] . '.' . $new_extension;
    }

Viewing 15 lines of 125 lines. View entire code block.

 
<?php
namespace Application\Src;
use Config;
use Loader;
use Image;
use \Imagine\Image\Box;
use Imagine\Image\ImageInterface;
use \Imagine\Image\Point\Center;
use \Concrete\Core\File\File;
class JpegImageHelper
{   
    function replace_extension($filename, $new_extension) {
        $info = pathinfo($filename);
        return $info['filename'] . '.' . $new_extension;
    }
 
    protected $jpegCompression;
    /**
     * Overrides the default or defined JPEG compression level per instance
     * of the image helper. This allows for a single-use for a particularly
     * low or high compression value. Passing a non-integer value will reset
     * to the default system setting (DEFINE or 80)
     * @param int $level the level of compression
     * @return self
     */
    public function setJpegCompression($level) {
        if (is_int($level)) {
            $this->jpegCompression = min(max($level, 0), 100);
        }
        return $this;
    }
    protected function getJpegCompression()
    {
        if (!isset($this->jpegCompression)) {
            $this->jpegCompression = \Config::get('concrete.misc.default_jpeg_image_compression');
        }
        return $this->jpegCompression;
    }
    /**
     * Deprecated. Use the Image facade instead.
     * @deprecated
     */
    public function create($mixed, $newPath, $width, $height, $fit = false)
    {
        if ($mixed instanceof \Imagine\Image\ImageInterface) {
            $image = $mixed;
        } else {
            $image = Image::open($mixed);
        }
        if ($fit) {
            return $image->thumbnail(new Box($width, $height), ImageInterface::THUMBNAIL_OUTBOUND)->save($newPath, array('quality'=>$this->getJpegCompression()));
        } else {
            if ($height < 1) {
                $image->thumbnail($image->getSize()->widen($width))->save($newPath, array('quality'=>$this->getJpegCompression()));
            } else if ($width < 1) {
                $image->thumbnail($image->getSize()->heighten($height))->save($newPath, array('quality'=>$this->getJpegCompression()));
            } else {
                $image->thumbnail(new Box($width, $height))->save($newPath, array('quality'=>$this->getJpegCompression()));
            }
        }
     }
    /**
     * Deprecated
     */
    /**
     * Returns a path to the specified item, resized and/or cropped to meet max width and height. $obj can either be
     * a string (path) or a file object.
     * Returns an object with the following properties: src, width, height
     * @param mixed $obj
     * @param int $maxWidth
     * @param int $maxHeight
     * @param bool $crop
     */
    public function getThumbnail($obj, $maxWidth, $maxHeight, $crop = false) {
        $fID = false;
        $fh = Loader::helper('file');
        if ($obj instanceof File) {
            try {
                $fr = $obj->getFileResource();
              $fID = $obj->getFileID();
                $filename = md5(implode(':', array($fID, $maxWidth, $maxHeight, $crop, $fr->getTimestamp())))
                . '.' . 'jpg';
            } catch(\Exception $e) {
                $filename = '';
            }
        } else {
            $filename = md5(implode(':', array($obj, $maxWidth, $maxHeight, $crop, filemtime($obj))))
                . '.' . $fh->getExtension($obj);
        }
        if (!file_exists(Config::get('concrete.cache.directory') . '/' . $filename)) {
            if ($obj instanceof File) {
                $image = \Image::load($fr->read());
            } else {
                $image = \Image::open($obj);
            }
            // create image there
            $this->create($image,
                          Config::get('concrete.cache.directory') . '/' . $filename,
                $maxWidth,
                $maxHeight,
                $crop);
        }
        $src = REL_DIR_FILES_CACHE . '/' . $filename;
        $abspath = Config::get('concrete.cache.directory') . '/' . $filename;
        $thumb = new \stdClass;
        if (isset($abspath) && file_exists($abspath)) {
            $thumb->src = $src;
            $dimensions = getimagesize($abspath);
            $thumb->width = $dimensions[0];
            $thumb->height = $dimensions[1];
            return $thumb;
        }
    }
    /**
     * Deprecated
     */
    public function outputThumbnail($mixed, $maxWidth, $maxHeight, $alt = null, $return = false, $crop = false) {
        $thumb = $this->getThumbnail($mixed, $maxWidth, $maxHeight, $crop);
        $html = '<img class="ccm-output-thumbnail" alt="' . $alt . '" src="' . $thumb->src . '" width="' . $thumb->width . '" height="' . $thumb->height . '" />';
        if ($return) {
            return $html;
        } else {
            print $html;
        }
    }
}

4) Use it like this:

use Application\Src\JpegImageHelper as ImageCompressor;
$ih = new ImageCompressor();
$ih->setJpegCompression(79);

From there, you can use it as you'd normally use the image helper. It's not the prettiest solution but it works.

Forums

Developing (v7+)

[5.7] Image to JPG when generating a thumbnail?

Code

Post Reply

Delete Post

Mark Post as Spam

Destroy Spammer

Sign In?