8.5.4: ConcreteFileManager is broken in latest version

Permalink
I've used for years the following code to select images from the file manager:
<?php echo $form->label('', t('Additional Images')); ?>
<ul class="list-group multi-select-list multi-select-sortable" id="additional-image-list">
    <?php  foreach ($property->getImagesObjects() as $file) {
        if ($file) {
            $thumb = $file->getListingThumbnailImage();
            if ($thumb) {
                echo '<li class="list-group-item">' . $thumb . ' ' . $file->getTitle() . '<a><i class="pull-right fa fa-minus-circle"></i></a><input type="hidden" name="afid[]" value="' . $file->getFileID() . '" /></li>';
            }
        }
    }
    ?>
</ul>
<div href="#" id="launch_additional" data-launch="file-manager" class="ccm-file-selector">
    <div class="ccm-file-selector-choose-new"><?php echo t('Choose Images'); ?></div>
</div>

It worked in v8.3*, in v8.4* and in v8.5.2. Now It opens the file manager when I click on it and that's it, clicking on files does nothing, files don't get selected, the option Choose does nothing. It doesn't even select a single image.

Is it broken or they've changed something?

Also hovering over image disappears in a fraction of a second. But it works fine when I hover in the FM directly (in Dashboard)

PS. I see in the release note for v8.5.3 they say "Select Multiple now works from within the file manager again (thanks deek87)". Looks like it's not working in v8.5.4 AGAIN.

linuxoid
 
Parasek replied on at Permalink Reply
Parasek
It seems since 8.5.3 when you are using this code

multipleSelection: true,

it actually works now, but when you are in File Manager window you need to select ONE OR MORE images and then click arrow next to "Name" title and select "Choose Files".

It's a little counter-intuitive for me right now after lack of multiple file selection for so many months. Probably "Choose selected Files" should be a button on its own (or at least label should be added instead arrow).

I had ticket today concerning this "bug" and as developer it took me 2 hours to figure it out:D

Cheers

edit
and yeah, right clicking single image and selecting "Choose" doesn't work right now
linuxoid replied on at Permalink Reply
linuxoid
You're right. It does work ONLY if you click on that down-arrow button. I've never noticed that button anyway.

It's definitely a bug because the same thing doesn't work from the context menu. When you try to click on Choose in the menu it unselects the images and then does nothing, you can't even select a single image.

The image hover over the widget is also stuffed, it appears momentarily on mouse entering and exiting the thumb, it doesn't stay open while mouse is over it.