Developing (v7+)

add captcha to external form

Permalink October 28, 2014 at 11:20 AM

Hi there

After testing around for a while, I reached the point to ask you guys.

How the hack can I add a captcha validation to an external form?

myForm.php

$captcha = Loader::helper('validation/captcha');
<?php $captcha->display(); ?>
<?php $captcha->showInput(); ?>

This adds the Captcha. Great. But how to validate it?

In the Controller

$captcha = Loader::helper('validation/captcha');
echo "captcha: " . $captcha->check($_REQUEST['ccmCaptchaCode']);

This returns nothing. The Captcha is never validated...

Thanks a lot.

hutman replied on Oct 29, 2014 at 11:29 am Permalink Best Answer Reply

You should just need this in your controller

if (!$captcha->check()) {
     //error stuff goes here
}

It will find the correct captcha stuff in the post information and validate it.

Steff replied on Oct 30, 2014 at 1:59 am Permalink Reply

There must have been a typing error or somethink like this.

Thanks huntman. It works like a charm.

GrizzlyAdams replied on Apr 19, 2017 at 8:59 pm Permalink Reply

Can u post what you have in your controller? I am unable to get this to validate the captcha

hutman replied on Apr 19, 2017 at 9:01 pm Permalink Reply

What version of C5 are you using?

GrizzlyAdams replied on Apr 19, 2017 at 9:02 pm Permalink Reply

5.7

hutman replied on Apr 19, 2017 at 9:05 pm Permalink Reply

I have this in the controller

$captcha = Core::make("captcha");
if (!$captcha->check()) {
    $this->error->add('Incorrect Captcha');
}

and in the view I have

<div class="form-group">
    <label class="control-label"><?php echo $captcha->label(); ?></label>
    <div><?php $captcha->display(); ?></div>
    <div><?php $captcha->showInput(); ?></div>
</div>

GrizzlyAdams replied on Apr 20, 2017 at 12:30 pm Permalink Reply

Hmm, I am getting a C5 error. Here's my action in the controller....

public function action_contact_us($bID = false)
    {
         $captcha = Core::make("captcha");
            if (!$captcha->check()) {
                $this->error->add('Incorrect Captcha');
            }
        if ($this->bID == $bID) {
         foreach($_POST as $key=>$value)
               {
                  if($key!=="send")
                  {
               $kkey = str_replace('_', ' ', $key);
                  if(is_array($value)){
                     $value = implode(', ', $value);
                  }

Viewing 15 lines of 38 lines. View entire code block.

 
 public function action_contact_us($bID = false)
    {
 
         $captcha = Core::make("captcha");
            if (!$captcha->check()) {
                $this->error->add('Incorrect Captcha');
            }
 
        if ($this->bID == $bID) {
 
 
 
         foreach($_POST as $key=>$value)
               {
                  if($key!=="send")
                  {
               $kkey = str_replace('_', ' ', $key);
 
 
                  if(is_array($value)){
                     $value = implode(', ', $value);
                  }
                   if($key=='Contact_Date_m' || $key=='Contact_Date_a' || $key=='submit'){
                      continue;
                   }elseif($key=='Contact_Date_dt'){
                     $addbody.='<strong>Contact Date</strong>: '.date('m-d-Y',strtotime($value)).'<br/><br/>';
                  }elseif($key=='Contact_Date_h'){
                     $addbody.='<strong>Contact Time</strong>: '.$_POST['Contact_Date_h'].':'.$_POST['Contact_Date_m'].' '.$_POST['Contact_Date_a'].'<br/><br/>';
                  }else{
                     $addbody.='<strong>'.$kkey.'</strong>: '.$value.'<br/><br/>';
                  }
                  }
 
 
 
               }
               //echo $addbody;
               //$addbody.='<strong>Submit this form to</strong> .';
               $body=$addbody; 
 
               $mh = Loader::helper('mail');
               $mh->to('customerservice@thebank.com');
               $mh->from('customerservice@thebank.com');
               $mh->setSubject('Contact form');
               $mh->setBodyHtml($body);
               $mh->sendMail();
 
            $this->set('response', t('Thank you. We will be in touch with you as requested.'));
 
        }
 
 
 
 
    }

hutman replied on Apr 20, 2017 at 12:33 pm Permalink Reply

What is the error you are getting?

GrizzlyAdams replied on Apr 20, 2017 at 12:36 pm Permalink Reply 1 Attachment

I attached a screenshot. It seems that it's not even seeing the Captcha. If I take out the captcha, the form processes fine.

hutman replied on Apr 20, 2017 at 12:48 pm Permalink Reply

2 things:
1) Do you have use Core; at the top of the controller?
2) Can you change your debug settings to see the actual error?

GrizzlyAdams replied on Apr 20, 2017 at 12:47 pm Permalink Reply

I assume it doesn't matter the captcha? It's the "I'm not a robot" one. Also, I have $captcha = Loader::helper('validation/captcha'); in the top of the view.

GrizzlyAdams replied on Apr 20, 2017 at 12:49 pm Permalink Reply

This is what's above my action in the top of the controller....

<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Loader;
class ContactFormPopup extends AbstractController
{

hutman replied on Apr 20, 2017 at 12:54 pm Permalink Reply

Remove the use Loader; and put in use Core; loader is deprecated and shouldn't be used anymore.

GrizzlyAdams replied on Apr 20, 2017 at 1:01 pm Permalink Reply

Changed that and still got the error. Here's the debug....

Call to a member function add() on a non-object
/home/bankofel/public_html/application/blocks/external_form/form/controller/contact_form_popup.php
{
    public function action_contact_us($bID = false)
    {
         $captcha = Core::make("captcha");
            if (!$captcha->check()) {
                $this->error->add('Incorrect Captcha');
            }

hutman replied on Apr 20, 2017 at 1:04 pm Permalink Reply

Ok, so the issue is that you don't have an error object to add an error to, the captcha is incorrect. This code should really be inside of your if, not before it, otherwise it's probably getting called on the second form submit.

GrizzlyAdams replied on Apr 20, 2017 at 1:51 pm Permalink Reply

I don't get it, still not working :(

<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Core;
class ContactFormPopup extends AbstractController
{
    public function action_contact_us($bID = false)
    {
        if ($this->bID == $bID) {
         $captcha = Core::make("captcha");
            if (!$captcha->check()) {
                $this->error->add('Incorrect Captcha');
            }         
         foreach($_POST as $key=>$value)
               {

Viewing 15 lines of 49 lines. View entire code block.

 
<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Core;
 
class ContactFormPopup extends AbstractController
{
 
    public function action_contact_us($bID = false)
    {
 
        if ($this->bID == $bID) {
 
         $captcha = Core::make("captcha");
            if (!$captcha->check()) {
                $this->error->add('Incorrect Captcha');
 
            }         
 
         foreach($_POST as $key=>$value)
               {
                  if($key!=="send")
                  {
               $kkey = str_replace('_', ' ', $key);
 
 
                  if(is_array($value)){
                     $value = implode(', ', $value);
                  }
                   if($key=='Contact_Date_m' || $key=='Contact_Date_a' || $key=='submit'){
                      continue;
                   }elseif($key=='Contact_Date_dt'){
                     $addbody.='<strong>Contact Date</strong>: '.date('m-d-Y',strtotime($value)).'<br/><br/>';
                  }elseif($key=='Contact_Date_h'){
                     $addbody.='<strong>Contact Time</strong>: '.$_POST['Contact_Date_h'].':'.$_POST['Contact_Date_m'].' '.$_POST['Contact_Date_a'].'<br/><br/>';
                  }else{
                     $addbody.='<strong>'.$kkey.'</strong>: '.$value.'<br/><br/>';
                  }
                  }
 
 
 
               }
               //echo $addbody;
               //$addbody.='<strong>Submit this form to</strong> .';
               $body=$addbody; 
 
               $mh = Loader::helper('mail');
               $mh->to('customerservice@thebankofelkriver.com');
               $mh->from('customerservice@thebankofelkriver.com');
               $mh->setSubject('Contact form');
               $mh->setBodyHtml($body);
               $mh->sendMail();
 
            $this->set('response', t('Thank you. We will be in touch with you as requested.'));
 
        }
 
 
 
 
    }
 
    public function view()
    {
        $this->set('message', t('This is just an example of how a custom form works.'));
    }
}

hutman replied on Apr 20, 2017 at 1:59 pm Permalink Reply

<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Core;
class ContactFormPopup extends AbstractController
{
    public function action_contact_us($bID = false)
    {
        if ($this->bID == $bID)
        { 
            $captcha = Core::make("captcha");
            if ($captcha->check())
            { 
                foreach($_POST as $key=>$value)
                {

Viewing 15 lines of 54 lines. View entire code block.

 
<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Core;
 
class ContactFormPopup extends AbstractController
{
    public function action_contact_us($bID = false)
    {
        if ($this->bID == $bID)
        { 
            $captcha = Core::make("captcha");
            if ($captcha->check())
            { 
                foreach($_POST as $key=>$value)
                {
                    if($key!=="send")
                    {
                        $kkey = str_replace('_', ' ', $key);
 
                        if(is_array($value)){
                            $value = implode(', ', $value);
                        }
                        if($key=='Contact_Date_m' || $key=='Contact_Date_a' || $key=='submit'){
                            continue;
                        } elseif($key=='Contact_Date_dt'){
                            $addbody.='<strong>Contact Date</strong>: '.date('m-d-Y',strtotime($value)).'<br/><br/>';
                        } elseif($key=='Contact_Date_h'){
                            $addbody.='<strong>Contact Time</strong>: '.$_POST['Contact_Date_h'].':'.$_POST['Contact_Date_m'].' '.$_POST['Contact_Date_a'].'<br/><br/>';
                        } else{
                            $addbody.='<strong>'.$kkey.'</strong>: '.$value.'<br/><br/>';
                        }
                    }
                }
 
                //echo $addbody;
                //$addbody.='<strong>Submit this form to</strong> .';
                $body=$addbody; 
 
                $mh = Loader::helper('mail');
                $mh->to('customerservice@thebankofelkriver.com');
                $mh->from('customerservice@thebankofelkriver.com');
                $mh->setSubject('Contact form');
                $mh->setBodyHtml($body);
                $mh->sendMail();
 
                $this->set('response', t('Thank you. We will be in touch with you as requested.'));
            } else {
                $error = Core::make('helper/validation/error');
                $error->add(t('Incorrect Captcha'));
                $this->set('error', $error);
            }
        }
    }
 
    public function view()
    {
        $this->set('message', t('This is just an example of how a custom form works.'));
    }
}

GrizzlyAdams replied on Apr 20, 2017 at 2:11 pm Permalink Reply

Dang, was hopeful with that.

Whoops \ Exception \ ErrorException (E_RECOVERABLE_ERROR) 
Object of class Concrete\Core\Error\Error could not be converted to string
/home/bankofel/public_html/application/blocks/external_form/form/contact_form_popup.php
<div class="head_contact_form">
<div class="container">
<div class="row">
<div class="col-md-6 col-sm-6 col-xs-12 col-md-offste-3 col-sm-offset-3">
<div class="form_out">
<div class="alert alert-danger" style="display:none;"><?php echo $error?></div>
<?php if (isset($response)) { ?>
   <div class="alert alert-info"><?php echo $response?></div>

hutman replied on Apr 20, 2017 at 2:20 pm Permalink Reply

Change this line

<div class="alert alert-danger" style="display:none;"><?php echo $error?></div>

<div class="alert alert-danger" style="display:none;"><?php $error->output(); ?></div>

GrizzlyAdams replied on Apr 20, 2017 at 2:50 pm Permalink Reply

Man, didn't think this would be so darn difficult!

<?php $error->output(); ?> completely blows up my site :(

hutman replied on Apr 20, 2017 at 2:51 pm Permalink Reply

What does "completely blows up my site" mean? Gives you an error? Gives you a white screen?

GrizzlyAdams replied on Apr 20, 2017 at 2:54 pm Permalink Reply

It looks similar to the other error

Exception Occurred: /home/bankofel/public_html/application/blocks/external_form/form/contact_form_popup.php:13 Call to a member function output() on a non-object (1)

Weird that I can't load any page on the site either.

hutman replied on Apr 20, 2017 at 2:55 pm Permalink Reply

I'm guessing you get this when there are no errors, try this

<?php if($error){ ?>
<div class="alert alert-danger" style="display:none;"><?php $error->output(); ?></div>
<?php } ?>

GrizzlyAdams replied on Apr 20, 2017 at 3:00 pm Permalink Reply

Ok, well that got rid of that. However, I can still submit the form without checking the "I am not a robot" checkbox. That doesn't seem right...

hutman replied on Apr 20, 2017 at 3:03 pm Permalink Reply

Can you just post ALL of your code so we can see what we're dealing with.

GrizzlyAdams replied on Apr 20, 2017 at 3:09 pm Permalink Reply

Sure, here's the view code

<div class="head_contact_div"  style="display:none;"><?php
$form = Loader::helper('form');
$captcha = Loader::helper('validation/captcha');
defined('C5_EXECUTE') or die("Access Denied.");
?>
<div class="head_contact_form">
<div class="container">
<div class="row">
<div class="col-md-6 col-sm-6 col-xs-12 col-md-offste-3 col-sm-offset-3">
<div class="form_out">
<!--<div class="alert alert-danger" style="display:none;"><?php //echo $error?></div>-->
<?php if($error){ ?>
<div class="alert alert-danger" style="display:none;"><?php $error->output(); ?></div>
<?php } ?>
<?php if (isset($response)) { ?>

Viewing 15 lines of 147 lines. View entire code block.

 
<div class="head_contact_div"  style="display:none;"><?php
$form = Loader::helper('form');
$captcha = Loader::helper('validation/captcha');
defined('C5_EXECUTE') or die("Access Denied.");
?>
 
 
<div class="head_contact_form">
 
<div class="container">
<div class="row">
<div class="col-md-6 col-sm-6 col-xs-12 col-md-offste-3 col-sm-offset-3">
<div class="form_out">
<!--<div class="alert alert-danger" style="display:none;"><?php //echo $error?></div>-->
 
<?php if($error){ ?>
<div class="alert alert-danger" style="display:none;"><?php $error->output(); ?></div>
<?php } ?>
 
<?php if (isset($response)) { ?>
   <div class="alert alert-info"><?php echo $response?></div>
    <script type="text/javascript">$(document).ready(function(){$('.head_contact').trigger('click');});</script>
<?php }?>
<div class="c_from_outer" <?php if (isset($response)) {  echo 'style="display:none;"'; }?>>
<div class="form_hed">
<h3> How Can We Assist You?</h3>
<p>Prefer to talk to someone now? Call us at <a href="tel:555.555.5555">555.555.5555.</a></p>
</div>
 
 
<form method="post" id="contact_form" action="<?php echo $view->action('contact_us')?>">
 
 
 
    <div class="form-group">
        <label class="control-label head"><?php echo t('Your Name')?> <span>*</span></label>
        <?php echo $form->text('Name')?>
    </div>
    <div class="form-group">
        <label class="control-label head"><?php echo t('Zip Code')?> <span>*</span></label>
        <?php echo $form->text('Zip_Code')?>
    </div>
 
     <div class="form-group">
        <label class="control-label head"><?php echo t('How would you prefer to be contacted?')?> <span>*</span></label>
        <div class="rad_but">
        <?php echo $form->radio('How_would_you_prefer_to_be_contacted','Email')?>
        <span><?php echo t('Email')?></span>
        </div>
    </div>
 
 
     <div class="form-group">
 
        <?php echo $form->radio('How_would_you_prefer_to_be_contacted','Phone')?>
        <span><?php echo t('Phone')?></span>
    </div>
     <div class="form-group">
        <label class="control-label head"><?php echo t('Email Address')?> <span>*</span></label>
        <?php echo $form->email('Email_Address')?>
    </div>
 
    <div class="form-group">
        <label class="control-label head"><?php echo t('Phone Number')?> <span>*</span></label>
        <?php echo $form->text('Phone_Number')?>
 
    </div>
    <div class="form-group">
     <label class="control-label head "><?php echo t('When should we contact you? (optional)')?></label>
        <?php echo Core::make('helper/form/date_time')->datetime('Contact_Date', $tourDate); ?>
 
   </div> 
 
   <div class="form-group">
        <label class="control-label head"><?php echo t('Are you a customer of The Bank?')?> <span>*</span></label>
        <div class="rad_but">
        <?php echo $form->radio('Are_you_a_customer_of_The_Bank','Yes')?>
        <span><?php echo t('Yes')?></span>
        </div>
    </div>
     <div class="form-group">
 
        <?php echo $form->radio('Are_you_a_customer_of_The_Bank','No')?>
        <span><?php echo t('No')?></span>
    </div>
 
     <div class="form-group">
        <label class="control-label head"><?php echo t('Are there any details you would like us to know? (optional)')?></label>
        <p>Your privacy is important to us. Please do not include your account number or other confidential information.</p>
        <?php echo $form->textarea('Are_there_any_details_you_would_like_us_to_know')?>
 
    </div>
    <div class="form-group">
        <label class="control-label"><?php echo $captcha->label(); ?></label>
        <div><?php $captcha->display(); ?></div>
        <div><?php $captcha->showInput(); ?></div>
    </div>
 
    <div class="form-group">
        <input type="submit" name="submit" value="Submit Contact Information" class="btn btn-default" />
    </div>
 
</form>
</div>
<button title="Close (Esc)" type="button" class="mfp-close">×</button>
</div>
</div>
</div>
</div>
</div>
</div>
<style type="text/css">
#contact_form input.error{
    border-color: #eb1212;
    outline: 0;
    -webkit-box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075), 0 0 8px rgba(235, 18, 18, 1)rgba(235, 18, 18, 1);
    box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075), 0 0 8px rgba(235, 18, 18, 1);
}
</style>
<script type="text/javascript">
$(document).ready(function(){
   $('#contact_form input').focusout(function(){
 
      if($(this).attr('type')=='radio'){
         $('input[name='+$(this).attr('name')+']').removeClass('error');
      }else{
         $(this).removeClass('error');      
      }
 
      });
 
   $('#contact_form').submit(function(){
      $('.head_contact_form .alert-danger').html('').hide();
   var eerror=false;
   if($('#Name').val()==''){
      $('#Name').addClass('error');   
      eerror=true;
   }
   if($('#Zip_Code').val()==''){
      $('#Zip_Code').addClass('error');   
      eerror=true;
   }
 
   if($('input[name=How_would_you_prefer_to_be_contacted]:checked').length<=0){
      $('input[name="How_would_you_prefer_to_be_contacted"]').addClass('error');   
      eerror=true;
   }
   if($('#Email_Address').val()==''){
      $('#Email_Address').addClass('error');   
      eerror=true;
   }
 
   if($('#Phone_Number').val()==''){
      $('#Phone_Number').addClass('error');   
      eerror=true;
   }
   if($('input[name=Are_you_a_customer_of_The_Bank]:checked').length<=0){
      $('input[name=Are_you_a_customer_of_The_Bank]').addClass('error');   
      eerror=true;
   }
   if(eerror){
      $('.head_contact_form .alert-danger').html('Please Completed required fields').show();
   return false;
   }else{
      return true;
   }
 
   });   
   });
 
</script>
 
<?php ?>
 
<style type="text/css">
.form-group label span {
    color: red;
}
 
</style>

And here's the controller

<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Core;
class ContactFormPopup extends AbstractController
{
    public function action_contact_us($bID = false)
    {
        if ($this->bID == $bID)
        { 
            $captcha = Core::make("captcha");
            if ($captcha->check())
            { 
                foreach($_POST as $key=>$value)
                {

Viewing 15 lines of 54 lines. View entire code block.

 
<?php
namespace Application\Block\ExternalForm\Form\Controller;
use Concrete\Core\Controller\AbstractController;
use Core;
 
class ContactFormPopup extends AbstractController
{
    public function action_contact_us($bID = false)
    {
        if ($this->bID == $bID)
        { 
            $captcha = Core::make("captcha");
            if ($captcha->check())
            { 
                foreach($_POST as $key=>$value)
                {
                    if($key!=="send")
                    {
                        $kkey = str_replace('_', ' ', $key);
 
                        if(is_array($value)){
                            $value = implode(', ', $value);
                        }
                        if($key=='Contact_Date_m' || $key=='Contact_Date_a' || $key=='submit'){
                            continue;
                        } elseif($key=='Contact_Date_dt'){
                            $addbody.='<strong>Contact Date</strong>: '.date('m-d-Y',strtotime($value)).'<br/><br/>';
                        } elseif($key=='Contact_Date_h'){
                            $addbody.='<strong>Contact Time</strong>: '.$_POST['Contact_Date_h'].':'.$_POST['Contact_Date_m'].' '.$_POST['Contact_Date_a'].'<br/><br/>';
                        } else{
                            $addbody.='<strong>'.$kkey.'</strong>: '.$value.'<br/><br/>';
                        }
                    }
                }
 
                //echo $addbody;
                //$addbody.='<strong>Submit this form to</strong> .';
                $body=$addbody; 
 
                $mh = Loader::helper('mail');
                $mh->to('customerservice@thebank.com');
                $mh->from('customerservice@thebank.com');
                $mh->setSubject('Contact form');
                $mh->setBodyHtml($body);
                $mh->sendMail();
 
                $this->set('response', t('Thank you. We will be in touch with you as requested.'));
            } else {
                $error = Core::make('helper/validation/error');
                $error->add(t('Incorrect Captcha'));
                $this->set('error', $error);
            }
        }
    }
 
    public function view()
    {
        $this->set('message', t('This is just an example of how a custom form works.'));
    }
}

hutman replied on Apr 20, 2017 at 3:24 pm Permalink Reply

This code works fine for me if I remove the display: none; from the error->output div and the head_contact_div

GrizzlyAdams replied on Apr 20, 2017 at 4:03 pm Permalink Reply

Thanks for all your help but it just isn't working. I have to have those hidden. The form is in a modal. I don't understand why it still allows the form to submit if the captcha fails.

GrizzlyAdams replied on Apr 21, 2017 at 4:50 pm Permalink Reply

Me too.

I am wondering if maybe an AJAX submission would be better since this is in a modal? Problem is that on submit, the modal is closing before the captcha has a chance to validate. Any grand ideas about this?

ob7dev replied on Apr 22, 2017 at 2:50 am Permalink Reply

When the form gets posted the page reloads, meaning your modal is gone? If so then perhaps AJAX is the way to go.

Khurramali replied on Jun 28, 2016 at 7:11 am Permalink Reply

Thanks for sharing. This really helped.

Forums

Developing (v7+)

add captcha to external form

Code

Post Reply

Delete Post

Mark Post as Spam

Destroy Spammer

Sign In?