Download URL: Issue with output buffer
Permalink
This might not be a C5 issue but rather a symfony issue, but when making a request for a files' 'Tracked_URL' the 302 Redirect response has a duplicate <html> element in the response body. It doesn't seem to have any effect on browsers or the ability to download a file, but certain SEO software is parsing the response body and marking the download urls as being bad for SEO. This was done with C5 8.5.1:
Repro:
select a file in the File Manager and get its 'Tracked_URL' from Properties
observe the raw request and response for the 'Tracked_URL'
Expected:
Redirect Response with a single <html> element in the response body
Actual:
duplicate <html> element in the response body
I traced through the source to get to the send() method of:
concrete\vendor\symfony\http-foundation\Response.php
ln: 376
If I change this line and set the second argument to false, so that there is a clear() instead of flush(), the body element is no longer duplicated but then several headers are duplicated, including the Location header, which is probably worse. Can anyone verify this and then where do I take it to get a fix in the queue?
Repro:
select a file in the File Manager and get its 'Tracked_URL' from Properties
observe the raw request and response for the 'Tracked_URL'
Expected:
Redirect Response with a single <html> element in the response body
Actual:
duplicate <html> element in the response body
I traced through the source to get to the send() method of:
concrete\vendor\symfony\http-foundation\Response.php
ln: 376
static::closeOutputBuffers(0, true);
If I change this line and set the second argument to false, so that there is a clear() instead of flush(), the body element is no longer duplicated but then several headers are duplicated, including the Location header, which is probably worse. Can anyone verify this and then where do I take it to get a fix in the queue?
