Developing (v7+)

Fileset reorder not saving in 5.5.2.1

Permalink May 27, 2012 at 9:19 PM

Hi
When I re-order the files in a fileset and press save.. then come back and open up the fileset again.. the order has not changed. My assumption is that it is not just a display issue as my gallery reflects the un-updated fileset order? How can I check to see if I am actually changing the fileset order via the dashboard "Files in Set" tab re-ordering function.

Ekko replied on May 28, 2012 at 3:26 am Permalink Reply

I had the same issue, and upgraded to 5.5.2. which has this resolved. It's also a minimal update so you should have no worries clicking the update button.

jolly replied on May 28, 2012 at 6:04 am Permalink Reply

Hi

This install is on the latest version (5.5.2.1) so I am not sure why yours was fixed by upgrading.

Ekko replied on May 28, 2012 at 7:07 am Permalink Reply

Because I upgraded to 5.5.2, and your version is not the latest

http://www.concrete5.org/about/blog/core-releases/concrete5-5-5-2-n...

jolly replied on May 28, 2012 at 6:32 pm Permalink Reply

Hi
Not that it matters as it doesn't solve my problem but 5.5.2.1 is a newer release (April 18) than the one you mentioned you have upgraded to... so I would need to downgrade to get to 5.5.2 (March 29)
So my question would be then has something reverted back in the newest version that has re-introduced a solved issue in 5.5.2. Maybe its more a permissions issue that is stopping the fileset reordering from saving?

jolly replied on May 31, 2012 at 1:34 am Permalink Reply

I have found something out today. Most of my filesets will actually behave the way I thought they should.. move images save, come back and they have been moved as per the save. The only 2 things that were different is that 1. The ones that won't save position when I move them are also in a larger fileset (effectivly they are a subset).. if I go and move them in the larger filest.. they save their moved position OK. Hmm thought this was an easy solve.. just take them out of the larger fileset and all should be OK.. No.. still cant move them and save that position.. hmmm.. now there is no "parent" fileset so cant move them at all.. hmm.. still pondering but at least I can confirm that most filesets save moved positions. 2. The fileset was "connected" to the Animant Image Gallery and I found out the hard way that if you delete the fileset before removing it from the image gallery.. code errors thrown page not accessible etc etc. Still pondering.

Brian1961 replied on Jul 8, 2012 at 9:05 am Permalink Reply

Hi

You are right... something is wrong here.

I have the same problem. It ignore the changes I make... they are not saved in the order I make.

I look at the info you wrote about being part of another fileset, and it helped to move it there as you write. So this must be a bug. as the idea is that the order of the filessets can be different. And it has worked this way before in older versions.

Has this been reported as a bug ? I think core team need to look at this, something is wrong here.

PS! I'm also using the latest version 5.5.2.1

Kind regards
Brian Nielsen

Brian1961 replied on Jul 8, 2012 at 9:21 am Permalink Reply

I have added this issue in the BUG Tracker...
http://www.concrete5.org/index.php?cID=354049...

webinstinct replied on Dec 3, 2012 at 1:33 pm Permalink Reply

Hey all. I had to dig out and solve this issue in 5.5.2, so here is the solution. The problem is actually not in the saving (which happens properly), but in the displaying (which does not).

In file: concrete/libraries/item_list.php

Find function sortByMultiple() near line 514

My code WAS this:

public function sortByMultiple() {
      $this->sortByString = implode(', ', func_get_args());
   }

Change this function to this:

public function sortByMultiple() {
      $args = func_get_args();
      $this->sortByString = implode(', ', $args);
   }

That solves it.

gailsedotes replied on Jun 5, 2013 at 9:15 am Permalink Reply

sorry did not work for me and funny and very bad that this was reported as a bug almost a year ago and nothing has been done about it.

BreakfastStudio replied on Feb 12, 2014 at 4:10 am Permalink Reply

I Know it's a bit late but it might help others who are still using 5.5.2 and 5.5.2.1. The bug is caused by a wrong SQL statement. To fix it go to concrete5rootdir/concrete/models/file_list.php at line 114 change this function

protected function setupFileSetFilters() {   
      $fsIDs = array_unique($this->filteredFileSetIDs);
      $fsIDs = array_filter($fsIDs,'is_numeric');
      $db = Loader::db();
      $i = 0;
      if(is_array($fsIDs) && count($fsIDs)) {
         foreach($fsIDs as $fsID) {
            if($fsID > 0) {
               if ($i == 0) {
                  $this->addToQuery("left join FileSetFiles fsfl on fsfl.fID = f.fID");
               }
               $this->filter(false,'f.fID IN (SELECT DISTINCT fID FROM FileSetFiles WHERE fsID = '.$db->quote($fsID).')');
               $i++;
            }
         }

Viewing 15 lines of 17 lines. View entire code block.

 
   protected function setupFileSetFilters() {   
      $fsIDs = array_unique($this->filteredFileSetIDs);
      $fsIDs = array_filter($fsIDs,'is_numeric');
 
      $db = Loader::db();
 
      $i = 0;
      if(is_array($fsIDs) && count($fsIDs)) {
         foreach($fsIDs as $fsID) {
            if($fsID > 0) {
               if ($i == 0) {
                  $this->addToQuery("left join FileSetFiles fsfl on fsfl.fID = f.fID");
               }
               $this->filter(false,'f.fID IN (SELECT DISTINCT fID FROM FileSetFiles WHERE fsID = '.$db->quote($fsID).')');
               $i++;
            }
         }
      }
   }

to this

protected function setupFileSetFilters() {   
      $fsIDs = array_unique($this->filteredFileSetIDs);
      $fsIDs = array_filter($fsIDs,'is_numeric');
      $db = Loader::db();
      $i = 0;
      $_fsIDs = array();
      if(is_array($fsIDs) && count($fsIDs)) {
         foreach($fsIDs as $fsID) {
            if($fsID > 0) {
               $_fsIDs[] = $fsID;
            }
         }
      }
      if (count($_fsIDs) > 1) {
         foreach($_fsIDs as $fsID) {

Viewing 15 lines of 34 lines. View entire code block.

 
protected function setupFileSetFilters() {   
      $fsIDs = array_unique($this->filteredFileSetIDs);
      $fsIDs = array_filter($fsIDs,'is_numeric');
 
      $db = Loader::db();
      $i = 0;
      $_fsIDs = array();
      if(is_array($fsIDs) && count($fsIDs)) {
         foreach($fsIDs as $fsID) {
            if($fsID > 0) {
               $_fsIDs[] = $fsID;
            }
         }
      }
 
      if (count($_fsIDs) > 1) {
         foreach($_fsIDs as $fsID) {
            if($fsID > 0) {
               if ($i == 0) {
                  $this->addToQuery("left join FileSetFiles fsfl on fsfl.fID = f.fID");
               }
               $this->filter(false,'f.fID IN (SELECT DISTINCT fID FROM FileSetFiles WHERE fsID = '.$db->quote($fsID).')');
               $i++;
            }
         }
      } else if (count($_fsIDs) > 0) {
         $this->addToQuery("inner join FileSetFiles fsfl on fsfl.fID = f.fID");
         $this->filter('fsfl.fsID', $fsID);
         $i++;
      }
 
      // add FileSetFiles if we had a file set filter but
      // couldn't add it because it has been removed
      if ($i == 0 && count($this->filteredFileSetIDs)>0) {
         $this->addToQuery("inner join FileSetFiles fsfl on 1=2");
      }      
   }

That code is from 5.6.

Forums

Developing (v7+)

Fileset reorder not saving in 5.5.2.1

Code

Post Reply

Delete Post

Mark Post as Spam

Destroy Spammer

Sign In?