Developing (v7+)

Hide blog thumbnail block if no image

Permalink February 26, 2015 at 4:56 AM

Hi guys, I have posted about this before and have had no reply so I've had no choice but to post about it again as the issue has risen its ugly head once again.

I'm using the premade blog_index_thumbnail.php template as my news page. This uses a block to show the thumbnail image, which is added via the composer. I have very little PHP knowledge and have no clue how using this block differs from attributes and which is better, but as it's there I'm using it.

The code looks like this:

<div class="image-link">
  <a <?php  if ($target != '') { ?> target="<?php echo $target?>" <?php  } ?> href="<?php echo $nh->getLinkToCollection($cobj)?>">
  <?php 
  $ts = $cobj->getBlocks('Thumbnail Image');
  if (is_object($ts[0])) {
    $tsb = $ts[0]->getInstance();
    $thumb = $tsb->getFileObject();
    if($thumb){
      $imgHelper->outputThumbnail($thumb, 800, 400, $title);
    } 
  }
  ?></a>
</div><!-- end image-link -->

My issue is, when there is no image added in the composer, that code still tries to show an image that isn't there, so I'm getting a broken image/border. I need an if statement around the whole thing to hide if there is no image added. Can anyone help?

gracehcoote replied on Mar 3, 2015 at 9:35 am Permalink Reply

Can no one help me with this at all??

fudyartanto replied on Mar 3, 2015 at 10:14 am Permalink Reply

You already try use image helper..?
there is example

<?php
$ih = Loader::helper('image');
//from your code try this one
$thumb = $tsb->getFileObject(); 
if(is_object($thumb)){
    $imgThumb = $ih->getThumbnail($thumb, 800, 400, $title);
}
?>
<?php if(isset($imgThumb) && is_object($imgThumb)):?>
<img src="<?php echo $imgThumb->src?>" alt="<?php echo $title?>">
<?php endif;?>

So you only print the image if image exist

gracehcoote replied on Mar 4, 2015 at 5:37 am Permalink Reply

Thank you for replying!

I tried your code but I just get an error. There is already code at the start of the file to load the image helper, so I changed your code to match accordingly:

<?php 
   defined('C5_EXECUTE') or die("Access Denied.");
   $textHelper = Loader::helper("text");
   $imgHelper = Loader::Helper('image');
   $dateHelper = Loader::Helper('date');
   $isFirst = true;
   $thumb = $tsb->getFileObject(); 
   if(is_object($thumb)){
       $imgThumb = $imgHelper->getThumbnail($thumb, 800, 400, $title);
   }
</php>

However I am getting this error:

Fatal error: Call to a member function getFileObject() on a non-object in /home/mastercraft/public_html/concrete/blocks/page_list/templates/blog_index_thumbnail.php on line 9

This is line 9:

$thumb = $tsb->getFileObject();

The rest of the page is blank. Any ideas what I'm doing wrong?

fudyartanto replied on Mar 4, 2015 at 8:55 am Permalink Reply

sorry, your $tsb var not assign any value.. this is complete example from your code

<div class="image-link">
  <a <?php  if ($target != '') { ?> target="<?php echo $target?>" <?php  } ?> href="<?php echo $nh->getLinkToCollection($cobj)?>">
  <?php 
  $ih = Loader::helper('image');
  $ts = $cobj->getBlocks('Thumbnail Image');
  if (is_object($ts[0])) {
    $tsb = $ts[0]->getInstance();
    $thumb = $tsb->getFileObject();
    if(is_object($thumb)){
      $imgThumb = $ih->getThumbnail($thumb, 800, 400, false);
      echo is_object($imgThumb) ? "<img src='{$imgThumb->src}' alt=''/>" : "";
    } 
  }
  ?></a>
</div><!-- end image-link -->

if still not work, upload your complete code here.. I'll try to help

gracehcoote replied on Mar 4, 2015 at 11:52 am Permalink Reply

Thank you so much for your help on this - I'm totally lost on it tbh.

I have tried your new code and various different iterations of it but with no success, so here's the complete code for that page:

<?php 
   defined('C5_EXECUTE') or die("Access Denied.");
   $textHelper = Loader::helper("text");
   $imgHelper = Loader::Helper('image');
   $dateHelper = Loader::Helper('date');
   $isFirst = true;
   /* @var $dateHelper DateHeler */
   // now that we're in the specialized content file for this block type, 
   // we'll include this block type's class, and pass the block to it, and get
   // the content
   if (count($cArray) > 0) { ?>
   <?php 
   for ($i = 0; $i < count($cArray); $i++ ) {
      $cobj = $cArray[$i]; 
      $target = $cobj->getAttribute('nav_target');

Viewing 15 lines of 81 lines. View entire code block.

 
<?php 
   defined('C5_EXECUTE') or die("Access Denied.");
   $textHelper = Loader::helper("text");
   $imgHelper = Loader::Helper('image');
   $dateHelper = Loader::Helper('date');
   $isFirst = true;
   /* @var $dateHelper DateHeler */
   // now that we're in the specialized content file for this block type, 
   // we'll include this block type's class, and pass the block to it, and get
   // the content
 
   if (count($cArray) > 0) { ?>
 
   <?php 
   for ($i = 0; $i < count($cArray); $i++ ) {
      $cobj = $cArray[$i]; 
      $target = $cobj->getAttribute('nav_target');
 
      $title = $cobj->getCollectionName();
      $date = $dateHelper->formatDate($cobj->getCollectionDatePublic(), true); 
      $firstClass = $isFirst ? 'first-entry' : '';
      $isFirst = false;   
   ?>
 
   <div class="entry <?php echo $firstClass; ?>">
      <div class="image-link">
         <a <?php  if ($target != '') { ?> target="<?php echo $target?>" <?php  } ?> href="<?php echo $nh->getLinkToCollection($cobj)?>">
         <?php          
            $ts = $cobj->getBlocks('Thumbnail Image');
            if (is_object($ts[0])) {
               $tsb = $ts[0]->getInstance();
               $thumb = $tsb->getFileObject();
               if($thumb){
               $imgHelper->outputThumbnail($thumb, 800, 400, $title);
               } 
            }
         ?></a>
      </div><!-- end image-link -->
      <div class="entry-content">
         <div class="entry-title">
            <h5 class="entry-date"><?php echo $date; ?></h5>
            <h4><a <?php  if ($target != '') { ?> target="<?php echo $target?>" <?php  } ?> href="<?php echo $nh->getLinkToCollection($cobj)?>"><?php echo $title?></a></h4>
 
         </div><!-- end title -->
 
         <!-- <h3><a <?php  if ($target != '') { ?> target="<?php echo $target?>" <?php  } ?> href="<?php echo $nh->getLinkToCollection($cobj)?>"><?php echo $textHelper->wordSafeShortText($title,$controller->truncateChars);?></a></h3> -->
         <p>
            <?php 
            if(!$controller->truncateSummaries){
               echo $cobj->getCollectionDescription();
            }else{
               echo $textHelper->wordSafeShortText($cobj->getCollectionDescription(),$controller->truncateChars);
            }
            ?>
         </p>
 
         <br />
         <a class="button" href="<?php echo $target; ?>"><?php echo t('Read full post'); ?></a>
      </div><!-- end entry-content -->
 
   </div><!-- end entry -->
 
<?php   } 
   if(!$previewMode && $controller->rss) { 
         $btID = $b->getBlockTypeID();
         $bt = BlockType::getByID($btID);
         $uh = Loader::helper('concrete/urls');
         $rssUrl = $controller->getRssUrl($b, 'blog_rss');
         ?>
         <div class="ccm-page-list-rss-icon">
            <a href="<?php echo $rssUrl?>" target="_blank"><img src="<?php echo $uh->getBlockTypeAssetsURL($bt, 'rss.png')?>" width="14" height="14" /></a>
         </div>
         <link href="<?php echo BASE_URL . $rssUrl?>" rel="alternate" type="application/rss+xml" title="<?php echo $controller->rssTitle?>" />
      <?php  
   } 
   ?>
 
<?php  }
 
   if ($paginate && $num > 0 && is_object($pl)): ?>
      <div id="pagination">
         <?php
         $summary = $pl->getSummary();
         if ($summary->pages > 1):
            $paginator = $pl->getPagination();
         ?>
            <span class="pagination-left">« <?php echo $paginator->getPrevious(t('Newer Posts')); ?></span>
            <span class="pagination-right"><?php echo $paginator->getNext(t('Older Posts')); ?> »</span>
            <?php echo $paginator->getPages(); ?>
         <?php endif; ?>
      </div>
   <?php endif; ?>

gracehcoote replied on Mar 4, 2015 at 5:44 am Permalink Reply

Tried again with some parts from your code but still showing the image even if one hasn't been added. Used this code:

if (is_object($ts[0])) {
    $tsb = $ts[0]->getInstance();
    $thumb = $tsb->getFileObject();
    if(isset($thumb) && is_object($thumb)){
        $imgHelper->outputThumbnail($thumb, 800, 400, $title);
    } 
}

gracehcoote replied on Jun 9, 2015 at 8:04 am Permalink Reply

Having found no solution for this that works, I've just had to use jQuery to sort the issue (and the same for another similar issue). In this case, even though no image is found, the <img> tag is still used, so I did a check to see if the src attribute was empty and if so to hide the parent element. Ended up with the following code:

$('img.ccm-output-thumbnail').each(function() {
  if($(this).attr("src") == "") {
    $(this).parent().parent().hide();
  }
});

Forums

Developing (v7+)

Hide blog thumbnail block if no image

Code

Post Reply

Delete Post

Mark Post as Spam

Destroy Spammer

Sign In?