Non-US dateformat, jquery datepicker and core c5
Permalink 2 users found helpful
I recently altered my site.php to set the dateformat to UK.
However on entering public date of 10/01/2011 (tenth of Jan) the datepicker shows that it thinks the date is 10 Jan 2011 which is right. Save the properties and then go back to the properties. Date has now changed to 01/10/2011 which is the US format of the date so it is first October, which is wrong.
It seems core c5 saves the date in the wrong format.
I referred to a previous post (http://www.concrete5.org/community/forums/chat/britisheuropean-getcollectiondatepublic-problem/?displayStyle=flat) which alludes to the bug being known and fixed in svn but on looking at the source of 5.4.1 it hasn't been changed.
I tried the temp solution outlined in that post but it doesn't fix the issue.
I've written about a similar issue around the Extended Form Addon and the dev says he is looking at it.
From my point of view it seems the non-US dateformat isn't exactly consistently supported in Core C5.
Am I wrong?
However on entering public date of 10/01/2011 (tenth of Jan) the datepicker shows that it thinks the date is 10 Jan 2011 which is right. Save the properties and then go back to the properties. Date has now changed to 01/10/2011 which is the US format of the date so it is first October, which is wrong.
It seems core c5 saves the date in the wrong format.
I referred to a previous post (http://www.concrete5.org/community/forums/chat/britisheuropean-getcollectiondatepublic-problem/?displayStyle=flat) which alludes to the bug being known and fixed in svn but on looking at the source of 5.4.1 it hasn't been changed.
I tried the temp solution outlined in that post but it doesn't fix the issue.
I've written about a similar issue around the Extended Form Addon and the dev says he is looking at it.
From my point of view it seems the non-US dateformat isn't exactly consistently supported in Core C5.
Am I wrong?
Date format is definitely an issue that would be good to addressed if possible.
Apart from a 'hear hear' there is not much more that I can add.
Apart from a 'hear hear' there is not much more that I can add.
bump. any news on that?
I was able to change the initial dateformat displayed by a datepicker by changing the GENERIC_DATEFORMAT in app.php. But as soon as I select another date it reverts back to US date format. ;(
I was able to change the initial dateformat displayed by a datepicker by changing the GENERIC_DATEFORMAT in app.php. But as soon as I select another date it reverts back to US date format. ;(
Sorry I stopped using C5 because ofd these issues.
Sorry if we only provided 80% of a solution with the original date constants.
I've just checked in an addition to github; You can now define another constant in config/site.php that is DATE_APP_DATE_PICKER, which controls the jQuery UI datepicker dateFormat property. Documentation on that property is here:
http://docs.jquery.com/UI/Datepicker/formatDate...
Practically speaking, for your issues, I would do the following:
1. Define your date constants as this:
I think part of the problem you were having is that d/m/Y is pretty ambiguous, and PHP's strtotime (which we use extensively) assumes this is an American date. (See the note on this page:http://php.net/strtotime) So I've changed the constants to use dashes, which will parse better.
2. Add this line to your site.php, and make sure you're using the latest concrete5 from github (or copy the latest change set from github out to your site:)
This will make jQuery UI datepicker keep the date in the same format, and parse the date string correctly.
Please let me know your thoughts on this solution.
I've just checked in an addition to github; You can now define another constant in config/site.php that is DATE_APP_DATE_PICKER, which controls the jQuery UI datepicker dateFormat property. Documentation on that property is here:
http://docs.jquery.com/UI/Datepicker/formatDate...
Practically speaking, for your issues, I would do the following:
1. Define your date constants as this:
I think part of the problem you were having is that d/m/Y is pretty ambiguous, and PHP's strtotime (which we use extensively) assumes this is an American date. (See the note on this page:http://php.net/strtotime) So I've changed the constants to use dashes, which will parse better.
2. Add this line to your site.php, and make sure you're using the latest concrete5 from github (or copy the latest change set from github out to your site:)
define('DATE_APP_DATE_PICKER', 'dd-mm-yy');
This will make jQuery UI datepicker keep the date in the same format, and parse the date string correctly.
Please let me know your thoughts on this solution.
80%? Ah sarcasm. How utterly pointless and unnecessary.
:( It actually wasn't sarcasm. I just found myself looking through the code certain that there must be a programmatic way through the date form helper to set the dateFormat and was mystified that we had never actually exposed a way to do that.
So in short is there a way to fix this in the current stable version (5.4.2 - as downloaded from SF)?
I think I'm missing something. I'm a bit of a newb but fairly tech savy - in as much as I can follow basic instructions! :)
I've tried what's mentioned here (ie added the 3+1 lines to config/site.php) and it doesn't change the format in the dashboard. Or are the first 3 lines meant to go somewhere else?
I also had a look athttp://www.concrete5.org/community/forums/chat/britisheuropean-getc... and checked concrete/models/attribute/types/date_time/controller.php and it has the required line: $value = date('Y-m-d H:i:s', strtotime($value));
There is some more info here:http://www.concrete5.org/community/forums/internationalization/brit... but I can't make sense of what needs doing.
Help on how to set non-US default date (ie dd/mm/yy) would be muchly appreciated
I think I'm missing something. I'm a bit of a newb but fairly tech savy - in as much as I can follow basic instructions! :)
I've tried what's mentioned here (ie added the 3+1 lines to config/site.php) and it doesn't change the format in the dashboard. Or are the first 3 lines meant to go somewhere else?
I also had a look athttp://www.concrete5.org/community/forums/chat/britisheuropean-getc... and checked concrete/models/attribute/types/date_time/controller.php and it has the required line: $value = date('Y-m-d H:i:s', strtotime($value));
There is some more info here:http://www.concrete5.org/community/forums/internationalization/brit... but I can't make sense of what needs doing.
Help on how to set non-US default date (ie dd/mm/yy) would be muchly appreciated
We should be releasing a point release next week that will have this in it.
Thanks heaps Andrew.
Is there a thread/blog/RSS or something I can subscribe to so I know when it's released?
Also you may be interested to know what I'm up to. I've created a(n unofficial) Turnkey Linux (TKL) Concrete5 appliance which will lower the bar for end users that wish to install Concrete5 to their own hardware (or VM etc). I'm fairly confident that the core devs will release an official version sometime soonish. I know from reading your license that this is ok. But it'd be even better to have your blessing. :)
Have a look at Turnkey Linux here:http://www.turnkeylinux.org
My TKLPatch is here:http://www.turnkeylinux.org/forum/general/20110820/tklpatch-concret...
PS Sorry to hijack your thread Steve.
Is there a thread/blog/RSS or something I can subscribe to so I know when it's released?
Also you may be interested to know what I'm up to. I've created a(n unofficial) Turnkey Linux (TKL) Concrete5 appliance which will lower the bar for end users that wish to install Concrete5 to their own hardware (or VM etc). I'm fairly confident that the core devs will release an official version sometime soonish. I know from reading your license that this is ok. But it'd be even better to have your blessing. :)
Have a look at Turnkey Linux here:http://www.turnkeylinux.org
My TKLPatch is here:http://www.turnkeylinux.org/forum/general/20110820/tklpatch-concret...
PS Sorry to hijack your thread Steve.
Should do the trick. Follow Andrews guide above, then:
Edit the line (141) in /concrete/helpers/form/date_time.php from:
$html .= '<script type="text/javascript">$(function() { $("#' . $id . '_dt").datepicker({ changeYear: true, showAnim: \'fadeIn\' }); });</script>';
to
$html .= '<script type="text/javascript">$(function() { $("#' . $id . '_dt").datepicker({ changeYear: true, showAnim: \'fadeIn\', dateFormat:\''.DATE_APP_DATE_PICKER.'\' }); });</script>';
Fixes the issue for me. (Must say, I haven't been through the code to see if there are any non-autostart implementations of this function in standard c5)
Edit the line (141) in /concrete/helpers/form/date_time.php from:
$html .= '<script type="text/javascript">$(function() { $("#' . $id . '_dt").datepicker({ changeYear: true, showAnim: \'fadeIn\' }); });</script>';
to
$html .= '<script type="text/javascript">$(function() { $("#' . $id . '_dt").datepicker({ changeYear: true, showAnim: \'fadeIn\', dateFormat:\''.DATE_APP_DATE_PICKER.'\' }); });</script>';
Fixes the issue for me. (Must say, I haven't been through the code to see if there are any non-autostart implementations of this function in standard c5)
I am still running 5.4.2 because 5.4.2.1 is not yet available through Dashboard.
But thought I still share this.
I have configured the date options for a Finnish date format in site.php like this:
But now if I go to the following pages and see the results:
/index.php/dashboard/
You logged in on 09/05/11 at 7:01 PM.
index.php/dashboard/system/jobs/
15.02.2011 at 1:08:14 PM
The "at" word is always visible and so is the AM/PM ending. They must be hardcoded somewhere.
But thought I still share this.
I have configured the date options for a Finnish date format in site.php like this:
But now if I go to the following pages and see the results:
/index.php/dashboard/
You logged in on 09/05/11 at 7:01 PM.
index.php/dashboard/system/jobs/
15.02.2011 at 1:08:14 PM
The "at" word is always visible and so is the AM/PM ending. They must be hardcoded somewhere.
'AM/PM': You forgot to put in config.php
'at': add translation files in languages folder.
But after all, in Dasboard (main page) you will see dates in xx/xx/xx format (like 31/01/2011).
I overcome this problem on my bilingual site (with new Internationalization addon active), with ‘old’ language switch code in config.php (see old posts on C5 forum):
(Change ‘hr_HR’ to your locale)
define('DATE_FORM_HELPER_FORMAT_HOUR', '24');
'at': add translation files in languages folder.
But after all, in Dasboard (main page) you will see dates in xx/xx/xx format (like 31/01/2011).
I overcome this problem on my bilingual site (with new Internationalization addon active), with ‘old’ language switch code in config.php (see old posts on C5 forum):
// Including the DIR_REL and the Domain, the two language character en, hr. $length_rel = strlen(DIR_REL); $sitelang = substr($_SERVER['REQUEST_URI'],$length_rel+1, 2); define('LANG', $sitelang); switch($sitelang) { case 'en': { define('LOCALE', 'en_US'); setlocale(LC_ALL,'en_US'); break; } default: { define('LOCALE', 'hr_HR'); setlocale(LC_ALL,'hr_HR'); break; }
Viewing 15 lines of 16 lines. View entire code block.
(Change ‘hr_HR’ to your locale)
Thanks.
I actually had the 24 settings in my site.php but adding the LC_ALL settings also seemed to make a difference in some pages.
I still have this 20.9.2011 at 10:59:55 PM in Jobs page though, so the settings does not affect every page.
But again a bit more forward. :)
I think these date and time settings should be added for example to the Multilingual page where the settings could be made centralized and you wouldn't have to seek out settings.
I actually had the 24 settings in my site.php but adding the LC_ALL settings also seemed to make a difference in some pages.
I still have this 20.9.2011 at 10:59:55 PM in Jobs page though, so the settings does not affect every page.
But again a bit more forward. :)
I think these date and time settings should be added for example to the Multilingual page where the settings could be made centralized and you wouldn't have to seek out settings.
You are right.
Look what I am reading (attach.) - I did not notice that before.
I do not have AM/PM notification any more, but time is shoving 1:36 instead 13:36!
Look what I am reading (attach.) - I did not notice that before.
I do not have AM/PM notification any more, but time is shoving 1:36 instead 13:36!
Yes, that's exactly what I am seeing in some places.
The settings are available in the site.php and some pages use them correctly. But then there are individual pages where some date or time format is not correct.
The settings are available in the site.php and some pages use them correctly. But then there are individual pages where some date or time format is not correct.
Yes, may biggest problem was with date_nav block translation (especially when this block is called programmatically from scrapbook). If you need template, let me know.
I have been going round in circles on trying to get a date-time attribute to consistently work with European format date of either dd-mm-yy or dd/mm/yy, using the settings noted in this thread and variations of them. But I can't get it to work consistently without corrupting at some stage. So maybe the issue has been solved for forms, but not for the date-time attribute.
I have decribed in more detail and posted a bug reporthttp://www.concrete5.org/index.php?cID=246534...
I have decribed in more detail and posted a bug reporthttp://www.concrete5.org/index.php?cID=246534...
I have just posted a 'tentative' correction for this on the above referenced bug report.
What is the situation on the European date format, now am I able to use
dd/mm/yy,
Previous attempts have always caused the date to reset, to 1970 which I am assuming is due to the parsing issue Andrew mentioned earlier, I am able to get dd-mm-yy to work but would prefer to be able to use "/" instead.
Is it safe to try using the "/" again?
This could do with being added to the developers guide.
Cheers
Sean
dd/mm/yy,
Previous attempts have always caused the date to reset, to 1970 which I am assuming is due to the parsing issue Andrew mentioned earlier, I am able to get dd-mm-yy to work but would prefer to be able to use "/" instead.
Is it safe to try using the "/" again?
This could do with being added to the developers guide.
Cheers
Sean
As of concrete 5.7.5.2 the datepicker() format used in custom forms appears to (sadly) be hard-coded in `/concrete/src/Form/Service/Widget/DateTime.php`.
The only way I found to change it was to inject the following Javascript in my page
The only way I found to change it was to inject the following Javascript in my page
$('.ccm-input-date.hasDatepicker').datepicker('option', 'dateFormat' ,'d M yy');
Thank you, very useful to know :)
Sorry if this is an unecessary question but how should the date format be changed in v8.2? The above fix doesn't seem to work for me nor anything else.
V8.2 has locale based date formatting, and switching the language in the members area sorts it enough for me.
Is that enough? or are you after something more custom?
Is that enough? or are you after something more custom?
Really no one has a view on this? Can the Core team please explain their view and what the issues are for non-default date formats? Is it that the dates as used in the Dashboard can't be altered or down to individual Addon devs to handle things if they want?
I was sur[rised there isn't an explanation of this in the documentation so at least non-US site devs know what the situation is to make a choice. The DATE_APP... settings aren't even explain, requires a search in the forums.
If C5 is to make a bigger UK impact, which I'd like to see, then this is something that is going to need to be solved or at least explained.
Thanks.