validation bug on all pages (5.3.3.1) - with solution
Permalink 1 user found helpful
concrete5 generates diffent "style" tags. But these are not validating, they are incorrect.
If we follow the correct definition of styles (as described inhttp://www.w3.org/TR/REC-html40/present/styles.html... ) we have to change these files:
/concrete/blocks/form/styles_include.php
/concrete/blocks/form/view.php
/concrete/blocks/google_map/form_setup_html.php
/concrete/blocks/google_map/view.php
/concrete/blocks/guestbook/view.php
/concrete/blocks/page_list/page_list_form.php
/concrete/blocks/rss_displayer/form_setup_html.php
/concrete/blocks/rss_displayer/view.php
/concrete/blocks/search/view.php
/concrete/blocks/search/form_setup_html.php
/concrete/blocks/slideshow/view.php
/concrete/blocks/slideshow/form_setup_html.php
/concrete/blocks/survey/view.php
/concrete/blocks/video/form_setup_html.php
/concrete/blocks/youtube/form_setup_html.php
/concrete/elements/collection_add.php
/concrete/elements/collection_metadata.php
/concrete/elements/collection_theme.php
/concrete/models/block_styles.php
/concrete/single_pages/dashboard/pages/themes/marketplace.php
/concrete/single_pages/dashboard/pages/themes/view.php
/concrete/single_pages/dashboard/scrapbook/view.php
/concrete/single_pages/dashboard/settings/view.php
/concrete/single_pages/dashboard/users/registration.php
/concrete/single_pages/dashboard/jobs.php
in these files we have to replace '<style>' with '<style type="text/css">'
Please can someone do this and add it to SVN / CVS?
Next thing is the following:
Authors should use the META element to set the default style sheet language for a document. For example, to set the default to CSS, authors should put the following declaration in the HEAD of their documents:
<META http-equiv="Content-Style-Type" content="text/css">
So we have to add this content line in standard meta tag output (which is done by /concrete/elements/header_required.php
If we follow the correct definition of styles (as described inhttp://www.w3.org/TR/REC-html40/present/styles.html... ) we have to change these files:
/concrete/blocks/form/styles_include.php
/concrete/blocks/form/view.php
/concrete/blocks/google_map/form_setup_html.php
/concrete/blocks/google_map/view.php
/concrete/blocks/guestbook/view.php
/concrete/blocks/page_list/page_list_form.php
/concrete/blocks/rss_displayer/form_setup_html.php
/concrete/blocks/rss_displayer/view.php
/concrete/blocks/search/view.php
/concrete/blocks/search/form_setup_html.php
/concrete/blocks/slideshow/view.php
/concrete/blocks/slideshow/form_setup_html.php
/concrete/blocks/survey/view.php
/concrete/blocks/video/form_setup_html.php
/concrete/blocks/youtube/form_setup_html.php
/concrete/elements/collection_add.php
/concrete/elements/collection_metadata.php
/concrete/elements/collection_theme.php
/concrete/models/block_styles.php
/concrete/single_pages/dashboard/pages/themes/marketplace.php
/concrete/single_pages/dashboard/pages/themes/view.php
/concrete/single_pages/dashboard/scrapbook/view.php
/concrete/single_pages/dashboard/settings/view.php
/concrete/single_pages/dashboard/users/registration.php
/concrete/single_pages/dashboard/jobs.php
in these files we have to replace '<style>' with '<style type="text/css">'
Please can someone do this and add it to SVN / CVS?
Next thing is the following:
Authors should use the META element to set the default style sheet language for a document. For example, to set the default to CSS, authors should put the following declaration in the HEAD of their documents:
<META http-equiv="Content-Style-Type" content="text/css">
So we have to add this content line in standard meta tag output (which is done by /concrete/elements/header_required.php
I think this is really an important thing to change, before the next version of concrete5 is released!
hey... all of the things are fixed in 5.4 ;-) very happy about that...
but now we have some new one's ;-)
/concrete/elements/block_area_layout.php
/concrete/js/tiny_mce/plugins/advlink/link.htm
/concrete/js/tiny_mce/plugins/inlinepopups/template.htm
/concrete/js/tiny_mce/plugins/paste/pasteword.htm
/concrete/js/tiny_mce/themes/concrete/image.htm
/concrete/js/tiny_mce/themes/concrete/link.htm
And still the standard meta tag output:
<META http-equiv="Content-Style-Type" content="text/css" />
is missing....
but now we have some new one's ;-)
/concrete/elements/block_area_layout.php
/concrete/js/tiny_mce/plugins/advlink/link.htm
/concrete/js/tiny_mce/plugins/inlinepopups/template.htm
/concrete/js/tiny_mce/plugins/paste/pasteword.htm
/concrete/js/tiny_mce/themes/concrete/image.htm
/concrete/js/tiny_mce/themes/concrete/link.htm
And still the standard meta tag output:
<META http-equiv="Content-Style-Type" content="text/css" />
is missing....