Validation of Concrete Sites and header_required.php and deeper
Permalink
Hi all!
I really like concrete 5. But up to now, it was always my goal to get a site through w3c validation service. But: header_required.php has a "flaw".
Line 93 (print $this->controller->outputHeaderItems();) seems to generate <style> ..</style> But this is not valid...
w3c.org says:
"The attribute given above is required for an element that you've used, but you have omitted it. For instance, in most HTML and XHTML document types the "type" attribute is required on the "script" element and the "alt" attribute is required for the "img" element.
Typical values for type are type="text/css" for <style> and type="text/javascript" for <script>."
Commenting out the line above was no help, as some other things were missing then. So I digged deeper.
It seems in this case line 58 in block_styles.php is the bad one. I commented it out (moving the file out of the core first), but I do not know what else it does. It seems all concrete5 sites i visited have an empty "<styles></styles>" somewhere generated by this line.
Furthermore some stuff from the marketplace isn't valid either. But I am sure this should be a goal for a great cms like concrete 5, it would keep me happy! Feel free to contact me for details.
Regards,
André
I really like concrete 5. But up to now, it was always my goal to get a site through w3c validation service. But: header_required.php has a "flaw".
Line 93 (print $this->controller->outputHeaderItems();) seems to generate <style> ..</style> But this is not valid...
w3c.org says:
"The attribute given above is required for an element that you've used, but you have omitted it. For instance, in most HTML and XHTML document types the "type" attribute is required on the "script" element and the "alt" attribute is required for the "img" element.
Typical values for type are type="text/css" for <style> and type="text/javascript" for <script>."
Commenting out the line above was no help, as some other things were missing then. So I digged deeper.
It seems in this case line 58 in block_styles.php is the bad one. I commented it out (moving the file out of the core first), but I do not know what else it does. It seems all concrete5 sites i visited have an empty "<styles></styles>" somewhere generated by this line.
Furthermore some stuff from the marketplace isn't valid either. But I am sure this should be a goal for a great cms like concrete 5, it would keep me happy! Feel free to contact me for details.
Regards,
André
http://www.concrete5.org/community/bugs/empty_andltstyleandgtandlts...
http://www.concrete5.org/community/bugs/style-tag-fixe/...
The core team usually merges patches into the core quite quickly..
Finding them is not difficult but why not help the core team by sending them patches?