Edit Bar Not Viewable After Making the Upgrade to 5.4.2

Permalink
Recently made the upgrade to 5.4.2 and since then the edit buttons have disappeared on the site. Space is created for them but the buttons do not show. Everything in the Dashboard works fine and the site works fine so at this point it looks like a CSS conflict but everything worked fine in 5.4.1. No custom changes have been made to the code for this site so everything is standard. Any ideas on a fix?

pixo
 
pmad replied on at Permalink Reply
Been running 5.4.1.1 and just upgraded last night to the 5.4.2. This morning I can no longer log in to the site. I have tried the hard refresh on the admin page, (control-R) or F5 and still nothing. The site looks to be operating, but I can't log in to do any editing. So, looks like we are in the same situation. I went to my webhost and tried to log on through there, but still, no access. Lets see if anyone has a solution. I reported the bug to concrete5. I tried to restore the site to the original version, but still can't log in.
Wanted to add this. Admin page will pop up and I enter password and username, but it takes me back to my site without it being in edit mode. I checked all my pages at the bottome and it doesn't show me logged in.
codingpenguins replied on at Permalink Reply
What do you mean? Does C5 take your login but then acts as if you are not logged in? Or is it giving you an error on the login?
pmad replied on at Permalink Reply
No, login doesn't give me any errors. It just goes back to my page without the edit bar. I went into my browser and opened it in Private mode. I then was able to enter my site. I cleared the cache and made some changes to the site, but when I leave the private browser, I can't log in.
pmad replied on at Permalink Reply
looking at the forum, looks like this is a widespread problem
pmad replied on at Permalink Reply
Not a fix, but it allows log-in. Maybe C5 will email me some ideas on why it works in Private. This tells me clear my cache, but that didn't seem to work. Anyone have other ideas? Tried F5, but nothing
codingpenguins replied on at Permalink Reply
My only suggestion is to look at the view source of a page with the edit buttons and see if the javascript throws any errors.
pixo replied on at Permalink Reply
pixo
Thanks for your reply. I'm not getting any javascript errors. The Edit buttons just don't appear.
codingpenguins replied on at Permalink Reply
I am not sure how good you are with php, but I think the only place the toolbar is created by is \concrete\tools\page_controls_menu_js.php (tested before). You can see if makes it to this file and if it does what permissions prevent certain buttons from displaying. I haven't upgraded, but I can assume that this file will be the same. The two places I would check:

if (isset($cp)) {


if ($cp->canWrite() || $cp->canAddSubContent() || $cp->canAdminPage() || $cp->canApproveCollection()) { ?>
Danives replied on at Permalink Reply
We have a similar issue - we have just updated to the latest version, and when viewing a pages properties there is no 'save' button anymore; no JavaScript errors, but have a PHP error which says:

Fatal error: Call to undefined method AttributeTypeView::field() in /home/sites/[sitename]/public_html/updates/concrete5.4.2/concrete/models/attribute/types/select/form.php on line 113
Steevb replied on at Permalink Reply
Steevb
This is strange!

So many problems with the much anticipated new release of C5.

There are a few similar problems, but not one common fault, at least not from what the forums are saying.

But on the plus side, In the past there were only three things that happened to me that Concrete didn't like.

My server, my style sheets and my Javascript.

My server played up when it moved to a new location or cPanel got upgraded, server support sorted it out.

My style sheets were not always prepared properly so things went weird.

I applied a bit of fancy javascript and all things went completely haywire.

My errors have caused the 'Edit bar' to disappear, the page layout to rearrange itself and the dashboard to hang on me.

My javascript also gave me some sort of weird error message I've never seen before, so I quickly backtracked.

For my part I changed my javascript slightly and coded my style sheet accordingly, problems solved.

So perhaps when using things concerning fancy CSS and javascript you might want to test and compromise a bit.

So possibly we need to check or someone does, the conflicts between the way we did things with C5 and the way we should now!


The only thing I can't do is use the Add Functionality section!

Update - Andrew has just fixed it for me.
pixo replied on at Permalink Reply
pixo
I tried a test. I changed the theme to Plain Yogurt and the Edit buttons still weren't appearing. The site is on the same server that it was on before the upgrade to 5.4.2. So unless there are new requirements for 5.4.2 server wise that I'm not aware of we can rule out CSS or server issues. I'm going to try re-uploading the C5 files and see if I don't have a bad or missing file that is causing the issue. If anyone else has any suggestions I'd love to hear them.
renatoiwa replied on at Permalink Reply
I am confirming this error. This is happening to my site. Any solution? It seems that the problem is related to this piece of code:

concrete/models/attribute/types/select/form.php
newRow.innerHTML='<input name="<?php echo $this->field('atSelectNewOption')?>[]" type="hidden" value="'+value+'" />';


Since the error says:
Call to undefined method AttributeTypeView::field()

I'm trying to fix this but it's taking some time to understand the context.

Can we get some help from Concrete5 team?
renatoiwa replied on at Permalink Reply
My client is complaining they cannot add pages! Please help! This is a critical problem!
shadowcomputers replied on at Permalink Reply
shadowcomputers
Hi all,

I have created a bug report for this, please can you all confirm it?
http://www.concrete5.org/developers/bugs/5-4-2/edit-bar-not-viewabl...

Thanks, Steve