concrete/config/localization.php not included in translation files

Permalink
From what I've seen the the date/time constants defined in localization.php are not included in most languages files. They also don't get picked up by poedit if you try to refresh from source files. Does anyone know why?

One example for a constant is
define('DATE_APP_GENERIC_MDY', t('n/j/Y'))

localization.php is here:https://github.com/concrete5/concrete5/blob/5.4.2.2/web/concrete/con...

PatrickHeck
 
Hypocrite replied on at Permalink Reply
Hypocrite
You should add the settings into the /config/site.php file.

These are the lines I usually include in my config:
define('DATE_APP_GENERIC_MDY', 'j.n.Y');
define('DATE_APP_GENERIC_MDYT_FULL', 'j.n.Y H:i:s');
define('DATE_APP_GENERIC_MDYT', 'j.n.Y H:i:s');
define('DATE_APP_DATE_PICKER', 'dd.mm.yy');
define('DATE_FORM_HELPER_FORMAT_HOUR', '24');


There are still some places in C5 where the settings are applied. So you might see the date format with AM/PM ending on some places.
PatrickHeck replied on at Permalink Reply
PatrickHeck
Actually forget my question. The constants are picked up perfectly in poedit and are also included in currend translation files. I am not sure why I didn't see that in the first place. So no need to to anything to make localized date formats work.