Forums

css not loading correctly for new Concrete 5.7 theme

Permalink
Im trying to convert a generic theme I downloaded off the web to Concrete 5.7, but having some issues where it doesn't load the css files.

Here's the code that I think is the problem:
<!--[if lte IE 8]><script src="<?=$view->getThemePath()?>/css/ie/html5shiv.js"></script><![endif]-->
      <script src="<?=$view->getThemePath()?>/js/jquery.min.js"></script>
      <script src="<?=$view->getThemePath()?>/js/jquery.dropotron.min.js"></script>
      <script src="<?=$view->getThemePath()?>/js/skel.min.js"></script>
      <script src="<?=$view->getThemePath()?>/js/skel-layers.min.js"></script>
      <script src="<?=$view->getThemePath()?>/js/init.js"></script>
      <noscript>
         <link rel="stylesheet" href="<?=$view->getThemePath()?>/css/skel.css" />
         <link rel="stylesheet" href="<?=$view->getThemePath()?>/css/style.css" />
      </noscript>
      <!--[if lte IE 8]><link rel="stylesheet" href="<?=$view->getThemePath()?>/css/ie/v8.css" /><![endif]-->


The css files in-between <noscript> don't seem to load for any device.

I removed the <noscript> tags and the css loads correctly on a desktop, but on a mobile device it fails to provide responsive features, i.e. doesn't load correctly on mobile.

For test pourposes, I have played with the html version of the template and modified the index.html file - I have removed the <noscript> tags and it too breaks the mobile responsive features exactly as the issue I had above. So I guess the <noscript> tags are necessary for the theme.

So if I leave the <noscript> tags in the theme, the css files fail to load, and if I remove it, the responsive features fail to load.

What can I do to fix this issue? Is there a way to get the css to load correctly within the <noscript> tags?

Here's the theme I downloaded:http://html5up.net/telephasic
 
mnakalay replied on at Permalink Reply
mnakalay
Hello,
The noscript tag serves one purpose: load what's in it if and only if javascript is disabled on the user's browser. Your css files between the noscript tags are not loading if your javascript is enabled. What it means is that these 2 css files are only supposed to load if the javascript features are broken because javascript is disabled. For instance, the menu is most likely a javascript feature.

So the question is, when you leave the noscript tag intact (and of course the files don't load) is anything broken?
pixelmargin replied on at Permalink Reply
pixelmargin
first thing you have to do is remove the jquery.min.js include from the theme as c5 will load it by default. Using more than one jquery may cause troubles on the dashboard and site.

and i am happy to help you on the theming if you wish to hire me. I can do it pretty quick and under $50

Let me know if interested. And my email is tinkutharasing(at)gmail.com and you can reach me on skype : tinkutr and i don't charge for minor fixes and requests . So you may keep my skype contact for any kind of help related to php/concrete5 etc

Thank you
hivoltage replied on at Permalink Best Answer Reply
I've sorted out the issue, thanks mnakalay for leading me on the right path.

The issue was not <noscript> as I first thought. A js file was loading the css files via code. I had to pass the theme path to the js file as a variable.

Used this example:
http://www.concrete5.org/community/forums/customizing_c5/paths-insi...
mnakalay replied on at Permalink Reply
mnakalay
Glad you managed it. Still I suggest you take into consideration what pixelmargin said about the double-loading of jQuery and check that you are not loading it twice