<?php
namespace Concrete\Core\Html\Service;
class Seo
{
    private $siteName = '';
    private $titleSegments = array();
    private $titleSegmentSeparator = ' - '; //1. I change this line to "-"
    private $titleFormat = '%1$s :: %2$s'; // 2. This value dont have any effect (the code works even when i delete this)
    private $hasCustomTitle = false;
 
    public function setSiteName($name)
    {
        $this->siteName = $name;
    }
 
    public function hasCustomTitle()
    {
        return $this->hasCustomTitle;
    }
 
    public function setCustomTitle($title)
    {
        $this->hasCustomTitle = true;
        $this->clearTitleSegments();
        $this->addTitleSegmentBefore($title);
        return $this;
    }
 
    public function addTitleSegment($segment)
    {
        array_push($this->titleSegments, $segment);
        return $this;
    }
 
    public function addTitleSegmentBefore($segment)
    {
        array_unshift($this->titleSegments, $segment);
        return $this;
    }
 
    public function clearTitleSegments()
    {
        $this->titleSegments = array();
    }
 
    public function setTitleFormat($format)
    {
        $this->titleFormat = $format;
        return $this;
    }
 
    public function setTitleSegmentSeparator($separator)
    {
        $this->titleSegmentSeparator = $separator;
        return $this;
    }
 
    public function getTitle()
    {
        $segments = '';
        if (count($this->titleSegments) > 0) {
            $segments = implode($this->titleSegmentSeparator, $this->titleSegments);
        }
        return sprintf($this->titleFormat, $segments, $this->siteName);//3. Change the order of parameters - This issue works fine "site name :: page name"
    }
}