Plugin submission
Permalink 2 users found helpful
Hi everyone
I submitted a plugin to the review board, but one of the automatic tests is failing. It says php file is not parsing correctly for one of my models. The file executes just fine. Does anybody know about this, or who i can contact?
Richard
I submitted a plugin to the review board, but one of the automatic tests is failing. It says php file is not parsing correctly for one of my models. The file executes just fine. Does anybody know about this, or who i can contact?
Richard
Hi john. The exec or die statement is actually there in the file. If the parsing error is about shell statements, does that mean i cant use them? They're kind of the center of the whole thing
It doesn't mean you absolutely can't use shell statements, especially as that is the whole point of what you are doing. However it does mean that you need to make that clear in the docs (which you have)and that the code will be given an extra hard going over. You will be expected to have built in error trapping in case they don't exist on a host, or return errors, and also to check it doesn't open security holes.
Your 'compatibility' testing script is a good move to help that along.
On the exec or die, it may be a side effect of the forbidden stuff, or it may be some silly syntax thing that prevents it from being detected, so maybe check that part character by character against one of your files that has passed.
Your 'compatibility' testing script is a good move to help that along.
On the exec or die, it may be a side effect of the forbidden stuff, or it may be some silly syntax thing that prevents it from being detected, so maybe check that part character by character against one of your files that has passed.
There is also the possibility that you are using other forbidden fns. Such failures are typically reading/writing files or json without using the official c5 helper. But that would normally give a different failure message.
Hi.
When I submit I get this error:
"Test Failed: Each PHP file contains exec or die statements"
I only use curl_exec (not exec()) in one file, and SOAPClient and DOMDocument(XML) in the second file.
Are they forbidden or encapsulated in a "native" Concrete5's method?
Maybe did I forget try-catch lines?
When I submit I get this error:
"Test Failed: Each PHP file contains exec or die statements"
I only use curl_exec (not exec()) in one file, and SOAPClient and DOMDocument(XML) in the second file.
Are they forbidden or encapsulated in a "native" Concrete5's method?
Maybe did I forget try-catch lines?
Hi arequal
What this error means is that one of your files does not start with:
<?php
defined("C5_EXECUTE") or die(_("Access Denied"));
This is required for each php file in the plugin.
Good luck with the submission process.
Richard
What this error means is that one of your files does not start with:
<?php
defined("C5_EXECUTE") or die(_("Access Denied"));
This is required for each php file in the plugin.
Good luck with the submission process.
Richard
Thousands of thanks. What kind of [CENSORED] am I ....? :-D
I fix and submit again.
I fix and submit again.
Make sure you take time to read this page:
http://www.concrete5.org/developers/marketplace-submission-rules/...
The boys and girls at the review board are quite strict about the rules.
http://www.concrete5.org/developers/marketplace-submission-rules/...
The boys and girls at the review board are quite strict about the rules.
I did it a lot of times... but s**t happens!!!
Thanks for the advice
Thanks for the advice
One of the errors shown is about a missing exec or die.
I suspect the other is because you are making shell calls.